fix(hooks): inject condensed instructions on SubagentStart#615
Open
arimu1 wants to merge 2 commits into
Open
Conversation
Subagents now receive getFallbackInstructions instead of the full mode-filtered SKILL.md, keeping Task-worker context smaller. Fixes DietrichGebert#597
|
Hi @arimu1, I added automated test coverage for the requirements discussed in #597. The test commit is
The tests verify the condensed SubagentStart payload, independent modes, matched and nonmatching agent behavior, fail-open cases, and the Claude, Codex, and Qoder paths. Could you please cherry-pick the commit into this PR? git cherry-pick 8110543 I closed #622 because it was accidentally opened against |
Author
|
Thanks @huda-code — cherry-picked |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SubagentStartpreviously injected the full mode-filteredSKILL.mdviagetPonytailInstructions(~5k+ chars).getSubagentInstructions()— the condensedgetFallbackInstructionspath (independent modes keep their short pointer string).Fixes #597
Test plan
ponytail-instructions/ compare lengths: condensed < full for modefullMade with Cursor